Messages in this thread | | | Subject | Re: [PATCH v1 04/11] stm class: stm_console: Add kernel-console-over-stm driver | From | Paul Bolle <> | Date | Sat, 21 Mar 2015 12:59:19 +0100 |
| |
All I spotted is two nits.
On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote: > +config STM_SOURCE_CONSOLE > + tristate "Kernel console over STM devices"
Tab instead of eight spaces, please.
> + default N
You meant default n
as n is a magic symbol. But n is the default anyway, so I think you might as well drop this line.
> + help > + This is a kernel space trace source that sends kernel log > + messages to trace hosts over STM devices. > + > + If you want to send kernel console messages over STM devices, > + say Y.
Paul Bolle
| |