Messages in this thread | | | Date | Fri, 20 Mar 2015 14:38:40 -0700 | From | Alexei Starovoitov <> | Subject | Re: [PATCH v8 tip 3/9] tracing: attach BPF programs to kprobes |
| |
On 3/20/15 2:09 PM, Steven Rostedt wrote: > >> +/** >> + * trace_call_bpf - invoke BPF program >> + * @prog - BPF program >> + * @ctx - opaque context pointer >> + * >> + * kprobe handlers execute BPF programs via this helper. >> + * Can be used from static tracepoints in the future. > > Should also state what the expected return values are. What does a > return of "1" mean?
In earlier versions of this set I had detailed description of return values from bpf program, somehow it got lost after all the revisions. Will re-add.
> You are no longer in the net/ world. The rest of the Linux coding style > is: > > /* > * multi line comments > */ > > Only DaveM gets away with that format ;-)
:) since bpf was born in the net/ world all comments are in that style. When it moved into kernel/bpf/ we've decided to keep net/ style in there as well, but for this file I don't mind using !net style ;)
> Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Thanks a lot. Will respin.
| |