lkml.org 
[lkml]   [2015]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core


On 15-03-20 02:26 PM, Dmitry Torokhov wrote:
> Hi Arun,
>
> On Fri, Mar 20, 2015 at 02:07:08PM -0700, Arun Ramamurthy wrote:
>> Adding devm_of_phy_get_by_index to get phys by supplying an index
>> and not a phy name when multiple phys are declared
>>
>> Reviewed-by: Ray Jui <rjui@broadcom.com>
>> Reviewed-by: Scott Branden <sbranden@broadcom.com>
>> Signed-off-by: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
>> ---
>> drivers/phy/phy-core.c | 30 ++++++++++++++++++++++++++++++
>> include/linux/phy/phy.h | 2 ++
>> 2 files changed, 32 insertions(+)
>>
>> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
>> index a12d353..0c03876 100644
>> --- a/drivers/phy/phy-core.c
>> +++ b/drivers/phy/phy-core.c
>> @@ -622,6 +622,36 @@ struct phy *devm_of_phy_get(struct device *dev, struct device_node *np,
>> EXPORT_SYMBOL_GPL(devm_of_phy_get);
>>
>> /**
>> + * devm_of_phy_get_by_index() - lookup and obtain a reference to a phy by index.
>> + * @dev: device that requests this phy
>> + * @np: node containing the phy
>> + * @index: index of the phy
>> + *
>> + * Gets the phy using _of_phy_get(), and associates a device with it using
>> + * devres. On driver detach, release function is invoked on the devres data,
>> + * then, devres data is freed.
>> + *
>> + */
>> +struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np,
>> + int index)
>> +{
>> + struct phy **ptr, *phy;
>> +
>> + ptr = devres_alloc(devm_phy_release, sizeof(*ptr), GFP_KERNEL);
>> + if (!ptr)
>> + return ERR_PTR(-ENOMEM);
>> +
>> + phy = _of_phy_get(np, index);
>> + if (!IS_ERR(phy)) {
>> + *ptr = phy;
>> + devres_add(dev, ptr);
>> + } else {
>> + devres_free(ptr);
>> + }
>> +
>> + return phy;
>> +}
>
> You want EXPORT_SYMBOL_GPL(devm_of_phy_get_by_index); here.
>
Ah, I missed that! Thanks Dmitry, Will update in next patch after any
other comments.
>> +/**
>> * phy_create() - create a new phy
>> * @dev: device that is creating the new phy
>> * @node: device node of the phy
>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
>> index a0197fa..ae2ffaf 100644
>> --- a/include/linux/phy/phy.h
>> +++ b/include/linux/phy/phy.h
>> @@ -133,6 +133,8 @@ struct phy *devm_phy_get(struct device *dev, const char *string);
>> struct phy *devm_phy_optional_get(struct device *dev, const char *string);
>> struct phy *devm_of_phy_get(struct device *dev, struct device_node *np,
>> const char *con_id);
>> +struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np,
>> + int index);
>> void phy_put(struct phy *phy);
>> void devm_phy_put(struct device *dev, struct phy *phy);
>> struct phy *of_phy_get(struct device_node *np, const char *con_id);
>> --
>> 2.3.2
>>
>


\
 
 \ /
  Last update: 2015-03-20 22:41    [W:0.091 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site