Messages in this thread | | | Date | Fri, 20 Mar 2015 14:09:43 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event() |
| |
On Fri, 20 Mar 2015 21:56:08 +0100 Fabian Frederick <fabf@skynet.be> wrote:
> ltp/fanotify02 was locked since commit 66ba93c0d7fe > ("fanotify: don't set FAN_ONDIR implicitly on a marks ignored mask")
What does "ltp/fanotify02 was locked" mean? That this particular test failed to exit, or...?
> --- a/fs/notify/fanotify/fanotify.c > +++ b/fs/notify/fanotify/fanotify.c > @@ -140,8 +140,8 @@ static bool fanotify_should_send_event(struct fsnotify_mark *inode_mark, > } > > if (d_is_dir(path->dentry) && > - !(marks_mask & FS_ISDIR & ~marks_ignored_mask)) > - return false; > + (marks_mask & FS_ISDIR & ~marks_ignored_mask)) > + return true;
Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)?
| |