lkml.org 
[lkml]   [2015]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex
On Fri 20 Mar 13:29 PDT 2015, Andy Gross wrote:

> On Thu, Mar 19, 2015 at 06:48:10PM -0700, Bjorn Andersson wrote:
>
> <snip>
>
> > +Example:
> > +
> > + tcsr: syscon@1a400000 {
>
> typo here, syscon@fd484000. And this syscon is specifically for the tcsr mutex
> reg area.
>

You're right, I didn't read the documentation good enough; let's name it
tcsr-mutex and as this is not the main tcsr region we should fall back
to just having syscon as compatible.

But there's still a bunch of other registers in the tcsr-mutex range -
that probably will be consumed by various drivers, so it still makes
sense to have a syscon there.

Sorry about the address, will update that as well.

> > + compatible = "qcom,tcsr-msm8974", "syscon";
> > + reg = <0xfd484000 0x2000>;
>

Regards,
Bjorn


\
 
 \ /
  Last update: 2015-03-20 22:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog