Messages in this thread | | | Date | Fri, 20 Mar 2015 18:19:26 +0000 | Subject | Re: [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL | From | Emil Velikov <> |
| |
On 20 March 2015 at 11:14, Javi Merino <javi.merino@arm.com> wrote: > We have grown a number of different implementations of > DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to > kernel.h so that it can be reused. > > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Darrick J. Wong <djwong@us.ibm.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Javi Merino <javi.merino@arm.com> > --- > drivers/gpu/drm/i915/intel_drv.h | 4 +--- > include/linux/kernel.h | 11 +++++++++++ > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index eef79ccd0b7c..346e28fdd7dd 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -28,6 +28,7 @@ > #include <linux/async.h> > #include <linux/i2c.h> > #include <linux/hdmi.h> > +#include <linux/kernel.h> Hi Javi,
Small suggestion - can we include the header only where needed ? i915/intel_panel.c seems to be the only user of DIV_ROUND_CLOSEST which will need an update.
Somewhat trivial pick but it will prevent ~40 unnecessary dives in kernel.h.
Cheers, Emil
| |