lkml.org 
[lkml]   [2015]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Drbd-dev] [PATCH] drbd: use bitmap_weight()
On Sat, Mar 14, 2015 at 10:12:56AM +0900, Akinobu Mita wrote:
> Use bitmap_weight to count the total number of bits set in bitmap.
> This change just simplifies the code a bit.

"Simplifies", not sure about that, but ok, maybe.

For the "bm_set_full_words_within_one_page", I disagree.
I think it is more cpu cache friendly to hweight_long then set to ~0UL
each word in turn, than to first bitmap_weight() all words, then
bitmap_fill() all words.

Thanks,

Lars Ellenberg

BTW, you swapped names and email addresses of phil and me. Are those
listed incorrectly somewhere, or was that just a mishap on your part?


\
 
 \ /
  Last update: 2015-03-20 16:21    [W:4.000 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site