Messages in this thread | | | Date | Fri, 20 Mar 2015 16:14:50 +0100 | From | Lars Ellenberg <> | Subject | Re: [Drbd-dev] [PATCH] drbd: use bitmap_weight() |
| |
On Sat, Mar 14, 2015 at 10:12:56AM +0900, Akinobu Mita wrote: > Use bitmap_weight to count the total number of bits set in bitmap. > This change just simplifies the code a bit.
"Simplifies", not sure about that, but ok, maybe.
For the "bm_set_full_words_within_one_page", I disagree. I think it is more cpu cache friendly to hweight_long then set to ~0UL each word in turn, than to first bitmap_weight() all words, then bitmap_fill() all words.
Thanks,
Lars Ellenberg
BTW, you swapped names and email addresses of phil and me. Are those listed incorrectly somewhere, or was that just a mishap on your part?
| |