lkml.org 
[lkml]   [2015]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: reorder can_do_mlock to fix audit denial
On Mon,  2 Mar 2015 09:20:32 -0800 Jeff Vander Stoep <jeffv@google.com> wrote:

> A userspace call to mmap(MAP_LOCKED) may result in the successful
> locking of memory while also producing a confusing audit log denial.
> can_do_mlock checks capable and rlimit. If either of these return
> positive can_do_mlock returns true. The capable check leads to an LSM
> hook used by apparmour and selinux which produce the audit denial.
> Reordering so rlimit is checked first eliminates the denial on success,
> only recording a denial when the lock is unsuccessful as a result of
> the denial.

I'm assuming that this is a minor issue - a bogus audit log, no other
consequences. And based on this I queued the patch for 4.0 with no
-stable backport.

All of this might have been wrong - the changelog wasn't very helpful
in making such decisions (hint).


\
 
 \ /
  Last update: 2015-03-03 02:01    [W:0.045 / U:1.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site