Messages in this thread | | | Date | Mon, 2 Mar 2015 16:53:15 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] pinctrl: imx: do not implicitly set pin regs to -1 |
| |
Hello,
On Mon, Mar 02, 2015 at 02:42:01PM +0100, Stefan Agner wrote: > On 2015-03-02 13:59, Uwe Kleine-König wrote: > > On Mon, Mar 02, 2015 at 07:45:17PM +0800, Shawn Guo wrote: > >> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote: > >> > Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs > >> > the values in struct imx_pin_reg to be -1. This has been done in a > >> > rather unorthodox way by setting the memory to 0xff using memset... > >> > Use a proper for loop to initialize the whole array with -1. > >> > > >> > Signed-off-by: Stefan Agner <stefan@agner.ch> > >> > >> Acked-by: Shawn Guo <shawn.guo@linaro.org> > > too late. This patch is part of 4.0-rc1 (4ff0f034e95d). > > This is not the same patch. The patch you are mentioning is actually > fixing a bug introduce in the change where we set -1 for uninitialized > pins. This patch is solving the weird assignment of the initial value... ah right.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |