Messages in this thread | | | Date | Thu, 19 Mar 2015 09:22:52 +0200 | From | Alex Dowad <> | Subject | Re: [23/32] powerpc: copy_thread(): rename 'arg' argument to 'kthread_arg' |
| |
On 19/03/15 08:45, Michael Ellerman wrote: > On Fri, 2015-13-03 at 18:14:46 UTC, Alex Dowad wrote: >> The 'arg' argument to copy_thread() is only ever used when forking a new >> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency >> with do_fork() and other arch-specific implementations of copy_thread()). > > I don't understand the bit about consistency with do_fork() ? This series of patches includes one patch which renames the arg for do_fork(), and others which rename the same arg for each arch-specific implementation of copy_thread(). So if all of them are accepted and merged, then all will be consistent. If only some of the patches are accepted, I will rewrite the commit message so it doesn't mention "consistency".
Thanks! AD > > Otherwise it looks fine. > > cheers
| |