Messages in this thread | | | Subject | Re: [PATCH] vfio: Split virqfd into a separate module for vfio bus drivers | From | Paul Bolle <> | Date | Thu, 19 Mar 2015 21:31:51 +0100 |
| |
On Thu, 2015-03-19 at 14:12 -0600, Alex Williamson wrote: > Well, at some point when I was doing vfio it seemed like a good idea and > I copied it from another driver.
For some time now I have this idea that there's a Linux kernel module template somewhere that uses defines like the ones you're using. That all started when I noticed drivers defining DRIVER_LICENSE. (I really like the name of that define.) Because every driver defining it ends up using it only once.
> Is it more valuable to remove a few lines of source code with no net > effect on the resulting output?
We should discuss this from the opposite direction: why is this patch adding a few lines with no obvious benefit?
> Besides, look at how much more aesthetically pleasing the above is > versus this: > > MODULE_VERSION("0.1"); > MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Alex Williamson <alex.williamson@redhat.com>"); > MODULE_DESCRIPTION("IRQFD support for VFIO bus drivers"); > > ;)
I don't do smileys. Perhaps that's why I never know what to think when someone uses them. Anyhow, sure, my comment is extremely trivial, but I do think I should raise this point just once. Because, well, ... because!
Paul Bolle
| |