Messages in this thread | | | Date | Thu, 19 Mar 2015 14:06:51 -0400 | From | Chris Metcalf <> | Subject | Re: [PATCH 28/32] tile: copy_thread(): rename 'arg' argument to 'kthread_arg' |
| |
On 03/16/2015 04:44 PM, Alex Dowad wrote: > > On 16/03/15 22:19, Chris Metcalf wrote: >> On 3/13/2015 2:14 PM, Alex Dowad wrote: >>> The 'arg' argument to copy_thread() is only ever used when forking a >>> new >>> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and >>> consistency >>> with do_fork() and other arch-specific implementations of >>> copy_thread()). >>> >>> Signed-off-by: Alex Dowad<alexinbeijing@gmail.com> >>> --- >>> arch/tile/kernel/process.c | 11 +++++++---- >>> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> Acked-by: Chris Metcalf <cmetcalf@ezchip.com> >> >> If you would prefer me to take this into the tile tree, let me know, >> and I am happy to do so. >> > Hi Chris, > > Thanks for your kind offer. I am a 100% genuine true-blue kernel > newbie and have no idea whether a change like this should be merged > individually by each arch maintainer, or all together at some point > upstream (or is it downstream? I'm not sure about my streams). Do you > have any suggestion? > > Thank you again! AD
I think James Hogan's replies were on-target [1]. My sense is that since it's a cleanup, and since you're trying for consistency, if you can gather up a few Acked-by's from maintainers, it probably makes sense to have it taken as a series.
[1] https://lkml.org/lkml/2015/3/16/477
-- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com
| |