lkml.org 
[lkml]   [2015]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver
One more thing:

> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
> pdev->dev.of_node);
> if (!match)
> return NULL;
> + if (match->data)
> + return match->data;
>
> + dev_warn(&pdev->dev, "DEPRECATED compatible property,"
> + "requires secure access to CCI registers");
> return probe_cci_model(pdev);
> }

Before the probe, could we please have:

if (!IS_ENABLED(CONFIG_ARM))
return -EINVAL;

On arm64 we require a model-specific string, and we shouldn't go
touching secure-only registers.

Mark.



\
 
 \ /
  Last update: 2015-03-19 19:01    [W:0.084 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site