Messages in this thread | | | Date | Thu, 19 Mar 2015 10:27:50 -0400 | From | Don Zickus <> | Subject | Re: perf: thread is its own parent |
| |
On Thu, Mar 19, 2015 at 07:56:32AM -0600, David Ahern wrote: > On 3/19/15 7:20 AM, Don Zickus wrote: > >Honestly I don't recall. The commit log tells you the problem I was trying > >to solve. Instead of parsing text strings from/proc/maps/<pid>, I believe > >it was waaaay faster to copy the thread maps. > > > >This could have been an oversight. I might have falsely assumed tgid == > >ppid? > > > >Are you finding a problem with it? > > > rebasing my scheduling timehist command to 4.0 and this change > breaks one of the options. If there are no objections I'll send a > patch along with others to set ptid and ppid to -1 (that's what it > is in 3.12).
Hmm, I wonder if this is going to break our threading example. Perhaps not, now that Jiri made some other changes later. Feel free to post a patch, cc me please. I will patch our perf over here and have Joe Mario run some tests to see if we lose any data or not and let you know.
Cheers, Don
| |