lkml.org 
[lkml]   [2015]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, mce, severities: Add AMD severities function
On Thu, Mar 19, 2015 at 12:01:32AM +0000, Luck, Tony wrote:
> One other thought. Instead of the run-time test to see if this is an AMD processor on every call
> to this function, would it be cleaner to:
>
> 1) Rename existing mce_severity() function to mce_severity_intel()
> 2) Declare a function pointer named mce_severity.
> 3) Assign that pointer to the _intel() or _amd() function in mce_init()

Yes, of course. We do that (or at least pretty close) in other paths
too.

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--


\
 
 \ /
  Last update: 2015-03-19 10:41    [W:0.102 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site