Messages in this thread Patch in this message | | | From | Tom Van Braeckel <> | Subject | [PATCH v2] checkpatch: support more uppercase $logFunctions | Date | Thu, 19 Mar 2015 09:26:41 +0100 |
| |
Add support for uppercase logging function names (so that they may exceed 80 cols) and regroup the matched expressions more logically.
Previously, WARN, WARN_RATELIMIT, WARN_ONCE were already supported but many other uppercase logging functions were not and this caused unfixable checkpatch warnings (an example: drivers/bluetooth/btusb.c)
Care was taken to avoid being overly broad by adding uppercase logging functions that do not exist (such as VDBG) or by making everything case insensitive.
Care was also taken to make sure that previously supported expressions are still matched (such as WARN_RATELIMIT and WARN_ONCE).
Signed-off-by: Tom Van Braeckel <tomvanbraeckel@gmail.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d124359..18d1ffa 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -352,7 +352,7 @@ our $typeTypedefs = qr{(?x: our $logFunctions = qr{(?x: printk(?:_ratelimited|_once|)| (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)| - WARN(?:_RATELIMIT|_ONCE|)| + (?:[A-Z0-9]+_){1,2}(?:EMERG|ALERT|CRIT|ERR|WARNING|WARN|NOTICE|INFO|DEBUG|DBG|DEVEL)(?:_RATELIMIT|_ONCE|)| panic| MODULE_[A-Z_]+| seq_vprintf|seq_printf|seq_puts -- 2.1.0
| |