Messages in this thread | | | Date | Wed, 18 Mar 2015 21:02:29 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering |
| |
Hello.
On 03/18/2015 07:54 PM, David Cohen wrote:
>>> ULPI PHYs need to be bound to their controllers with a >>> lookup. This adds helpers that the ULPI drivers can use to >>> do both, the registration of the PHY and the lookup, at the >>> same time.
>>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> >>> Cc: Kishon Vijay Abraham I <kishon@ti.com> >>> --- >>> drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++ >>> 1 file changed, 31 insertions(+) >>> create mode 100644 drivers/phy/ulpi_phy.h
>>> diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h >>> new file mode 100644 >>> index 0000000..ac49fb6 >>> --- /dev/null >>> +++ b/drivers/phy/ulpi_phy.h >>> @@ -0,0 +1,31 @@ >>> +#include <linux/phy/phy.h> >>> + >>> +/** >>> + * Helper that registers PHY for a ULPI device and adds a lookup for binding it >>> + * and it's controller, which is always the parent. >>> + */ >>> +static inline struct phy >>> +*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops)
>> Please either keep the prototype on a single line or don't break it like >> this. The result type should be all on the 1st line.
> IMHO this is quite fine and readable. We can find this style in many > places of the kernel.
It's the first time I'm seeing this particular "flavor".
> Maybe it's a matter of taste :)
Hopefully a good taste. :-) Some people also put the operator on the second line, when breaking up the expressions. Ew. :-)
> BR, David
>> [...]
WBR, Sergei
| |