Messages in this thread | | | Date | Wed, 18 Mar 2015 15:55:28 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read |
| |
On Wed 18-03-15 10:44:11, Rik van Riel wrote: > On 03/18/2015 10:09 AM, Michal Hocko wrote: > > page_cache_read has been historically using page_cache_alloc_cold to > > allocate a new page. This means that mapping_gfp_mask is used as the > > base for the gfp_mask. Many filesystems are setting this mask to > > GFP_NOFS to prevent from fs recursion issues. page_cache_read is, > > however, not called from the fs layer > > Is that true for filesystems that have directories in > the page cache?
I haven't found any explicit callers of filemap_fault except for ocfs2 and ceph and those seem OK to me. Which filesystems you have in mind?
Btw. how would that work as we already have GFP_KERNEL allocation few lines below?
-- Michal Hocko SUSE Labs
| |