Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH 4/9] Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY | Date | Wed, 18 Mar 2015 14:23:09 +0000 |
| |
> -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Wednesday, March 18, 2015 12:27 AM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com; Nick Meier > Subject: Re: [PATCH 4/9] Correcting truncation error for constant > HV_CRASH_CTL_CRASH_NOTIFY > > On Tue, Mar 17, 2015 at 05:41:56PM -0700, K. Y. Srinivasan wrote: > > From: Nick Meier <nmeier@microsoft.com> > > > > HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the > usage context, > > the value may be truncated. This patch is in response from the following > > email from Intel: > > "from Intel:" is really vague, please be nice and report who told you > about this problem. > > > > > [char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse: > > constant 0x8000000000000000 is so big it is unsigned long > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > char-misc-testing > > head: b3de8e3719e582f3182bb504295e4a8e43c8c96f > > commit: 96c1d0581d00f7abe033350edb021a9d947d8d81 [25/45] Drivers: > hv: vmbus: Add support for VMBus panic notifier handler > > reproduce: > > # apt-get install sparse > > git checkout 96c1d0581d00f7abe033350edb021a9d947d8d81 > > make ARCH=x86_64 allmodconfig > > make C=1 CF=-D__CHECK_ENDIAN__ > > > > sparse warnings: (new ones prefixed by >>) > > > > drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so > big it is unsigned long > > ... > > > > The current char-next branch is broken and this patch fixes > > the bug. > > > > Signed-off-by: Nick Meier <nmeier@microsoft.com> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > > You forgot a "Reported-by:" here.
Greg,
Should I resend the set with corrections to this patch.
Thanks,
K. Y
| |