Messages in this thread | | | Date | Wed, 18 Mar 2015 14:43:01 +0100 | From | Quentin Lambert <> | Subject | Re: [PATCH v2] Staging: dgnc: release the lock before testing for nullity |
| |
On 18/03/2015 14:36, Dan Carpenter wrote: > This changelog still doesn't make sense so I took a look at the code. > > tty_ldisc_deref() is an unlock function. So this is a lock ordering > bug. What makes you think the original ordering was correct? Who > reported this bug? What are the effects of this bug? I was the one who introduced the ordering change in the first place. I am just trying to fix it because although nobody complained I am not sure of the impact and restoring the previous control flow seems to be the right thing to do.
| |