Messages in this thread | | | Date | Wed, 18 Mar 2015 18:59:41 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset |
| |
On Wed, Mar 18, 2015 at 04:23:39PM +0300, Dan Carpenter wrote: > > https://lkml.org/lkml/2015/3/10/685 > > > > You were making random white space changes and not on the same line. It > was hard to review because you had to count how many u32 arguments there > were (a million) and really look at it to see what the compile warning > was. There was no compile warning in the end. Very annoying. ok, now understood. Thanks. like you said once - combining different changes in a single patch is an art. :)
regards sudip > > regards, > dan carpenter >
| |