Messages in this thread | | | Date | Wed, 18 Mar 2015 15:29:21 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH RFC] wimax/i2400m: fixup completion handling for resetting a device |
| |
Hello.
On 3/17/2015 12:49 PM, Nicholas Mc Guire wrote:
> wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the check > for > 0 in the else branch is always true and can be dropped. The comment seems > misleading as it is always going to pass the result up.
> The sync of the completion access with __i2400m_dev_reset_handle (which checks > for if (i2400m->reset_ctx) could race if i2400m_reset() returns negative so > the resetting of i2400m->reset_ctx == NULL is moved to the out: path.
> As wait_for_completion_timeout returns unsigned long not int, an appropriately > named variable of type unsigned long is added and assignments fixed up.
Don't try to do several things in one patch.
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
[...]
WBR, Sergei
| |