Messages in this thread | | | Date | Tue, 17 Mar 2015 17:04:20 +0100 | From | Arend van Spriel <> | Subject | Re: [PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion |
| |
On 03/17/15 13:06, Nicholas Mc Guire wrote: > Converting milliseconds to jiffies by "val * HZ / 1000" is technically > OK but msecs_to_jiffies(val) is the cleaner solution and handles all > corner cases correctly. This is a minor API consolidation only and > should make things more readable. > > Patch was compile tested with x86_64_defconfig + CONFIG_BRCMFMAC=m > > Patch is agianst 4.0-rc4 (localversion-next is -next-20150317)
It applies to wireless-drivers-next/master as well so
Acked-by: Arend van Spriel <arend@broadcom.com> > Signed-off-by: Nicholas Mc Guire<hofrat@osadl.org> > --- > drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c > index 9b805c9..1996dc2 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c > @@ -1110,7 +1110,7 @@ brcmf_cfg80211_escan(struct wiphy *wiphy, struct brcmf_cfg80211_vif *vif, > > /* Arm scan timeout timer */ > mod_timer(&cfg->escan_timeout, jiffies + > - WL_ESCAN_TIMER_INTERVAL_MS * HZ / 1000); > + msecs_to_jiffies(WL_ESCAN_TIMER_INTERVAL_MS)); > > return 0; >
| |