Messages in this thread | | | Date | Tue, 17 Mar 2015 08:33:27 -0700 | Subject | Re: [PATCHv3 xfstests 2/3] generic: test openat and new O_BENEATH flag | From | Kees Cook <> |
| |
On Mon, Mar 16, 2015 at 4:24 PM, Dave Chinner <david@fromorbit.com> wrote: > On Mon, Mar 09, 2015 at 02:00:11PM +0000, David Drysdale wrote: >> Test basic openat(2) behaviour. >> >> Test that if O_BENEATH flag is set, openat() will only >> open paths that have no .. component and do not start >> with /. Symlinks are also checked for the same restrictions. >> >> Signed-off-by: David Drysdale <drysdale@google.com> >> --- >> .gitignore | 1 + >> common/openat | 61 ++++++++++++++++++++++++++++++ >> src/Makefile | 3 +- >> src/openat.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++ > > This strikes me as something that shoul dbe added to xfs_io for > testing, as it already supports a heap of other open flags and > xfstests is already dependent on it.
While I don't see a problem adding this to xfs_io, I'd still like to see this test live in the kernel tree too. Having it in the same source means more testing, IMO.
-Kees
-- Kees Cook Chrome OS Security
| |