lkml.org 
[lkml]   [2015]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] kdbus: fix header guard name
From
Hi

On Tue, Mar 17, 2015 at 4:03 AM, <lucas.de.marchi@gmail.com> wrote:
> From: Lucas De Marchi <lucas.demarchi@intel.com>
>
> UAPI headers have a _UAPI_ as prefix, which is removed during
> headers_install. If it's put as a suffix it will not be removed and will
> be the only header with UAPI in the header guard macro.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> include/uapi/linux/kdbus.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/kdbus.h b/include/uapi/linux/kdbus.h
> index fc1d77d..302862f 100644
> --- a/include/uapi/linux/kdbus.h
> +++ b/include/uapi/linux/kdbus.h
> @@ -5,8 +5,8 @@
> * your option) any later version.
> */
>
> -#ifndef _KDBUS_UAPI_H_
> -#define _KDBUS_UAPI_H_
> +#ifndef _UAPI_KDBUS_H_
> +#define _UAPI_KDBUS_H_

Looks good, but lacks an update of the last line in this header:

#endif /* _KDBUS_UAPI_H_ */

With this comment changed:

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David!

> #include <linux/ioctl.h>
> #include <linux/types.h>
> --
> 2.3.3
>


\
 
 \ /
  Last update: 2015-03-17 10:01    [W:0.045 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site