Messages in this thread | | | Date | Mon, 16 Mar 2015 18:28:09 +0000 | From | Charles Keepax <> | Subject | Re: [PATCH 5/5] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode |
| |
On Mon, Mar 16, 2015 at 05:17:55PM +0000, Mark Brown wrote: > On Mon, Mar 16, 2015 at 04:58:44PM +0000, Charles Keepax wrote: > > > + } else { > > + switch (arizona->type) { > > + case WM5110: > > + case WM8280: > > + ret = regulator_set_voltage(arizona->dcvdd, > > + 1175000, 1175000); > > + if (ret < 0) { > > Can we please have a comment about this being the internal LDO and us > therefore knowing exactly what voltages it supports (or just that it's > the on chip LDO)? Going for a single voltage with zero tolerance is > usually bad practice since it causes needless interoperability issues > (eg, here the chances that the hardware would mind if an external > regulator were only able to deliver 1.174V rather than 1.175V are > minimal). This is fine here but people might be looking for examples > and get the wrong idea.
Yeah no problem I will respin and add that.
Thanks, Charles
| |