lkml.org 
[lkml]   [2015]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] phy: Add a driver for dm816x USB PHY
* Matthijs van Duin <matthijsvanduin@gmail.com> [150314 14:04]:
> On 13 March 2015 at 20:30, Tony Lindgren <tony@atomide.com> wrote:
> > Hmm OK have to check that. It could also be that dm816x documentation
> > is copy-paste from da850 or am3517 and the PHY got changed in the
> > hardware as the registers don't match the documentation. Only the
> > dm816x errata has right documentation for the USB PHY.
>
> Hmm? While I see plenty of usb errata (mostly DMA bugs), I don't see
> anything about registers being different.

Sorry it seems to be the partially updated TRM instead, it's the
sprs614e.pdf instead. That has the USBPHY_CTRL registers right.
No mention of Synopsys in sprs614e.pdf though so who knows. It
seems something got swapped compared to the TRM as the USB_CTRL
registers totally changed.

I'll just add a comments you mentioned earlier about it probably
being Synopsys phy.

> I do see something curious: advisory 70, the only PHY-related erratum
> I see, is also present in the DM814x errata and even in AM335x r1.0.
> This strongly suggests the PHYs must at least be closely related...

Hmm interesting. But dm814x has again different USB_CTRL registers,
seems to be wired up like am335x. Also there's no USBPHY_CTRL
registers on dm814x or am335x. Chances are that dm814x is wired up
the same way as am335x.

> The dm816x TRM makes three separate mentions of the synopsys usb phy
> though, while I found no other TRMs that mention it, so if it's a
> copy-paste error (which certainly would not be exceptional) I don't
> know where from.

Yes I checked am3517 trm, and that too mentions Synopsys once, but
has different registers. And also checked the l-138/da850 TRM, and
that does not have USB_CTRL and USBPHY_CTRL registers either.. Looks
like the copy paste errors come from tms320dm6446.pdf that has
the USB_CTRL and USBPHY_CTRL registers, but then no mention of
Synopsys.

> I suppose it's still possible TI acquired a sufficiently permissive
> license for the synopsys phy to fork it and call it a "TI PHY" as they
> do in the AM335x docs. (No mention of its origin is made in the DM814x
> docs.)
>
> BTW, da850? Is that yet another instance of Primus? (i.e.
> omap-L1xx/c674x/am1xxx with odd final digit, also da830/da828)

Yes it's the arm926 based series, l-138 is da850 I believe.

Regards,

Tony


\
 
 \ /
  Last update: 2015-03-16 18:01    [W:0.077 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site