lkml.org 
[lkml]   [2015]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 15/16] staging: rtl8723au: Correct a typo in a trace log line
    Date
    "M. Vefa Bicakci" <m.v.b@runbox.com> writes:
    > Correct a typo in rtl8723au's rtw_security.c which was most likely
    > caused by a copy and paste mistake. Prior to this commit, the TKIP
    > decryption function referred to WEP in its trace log output.
    >
    > Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
    > ---
    > drivers/staging/rtl8723au/core/rtw_security.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
    > index eb3544866a..e8d3ce53bb 100644
    > --- a/drivers/staging/rtl8723au/core/rtw_security.c
    > +++ b/drivers/staging/rtl8723au/core/rtw_security.c
    > @@ -757,7 +757,7 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
    >
    > if (actual_crc != expected_crc) {
    > RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
    > - ("rtw_wep_decrypt23a:icv CRC mismatch: "
    > + ("rtw_tkip_decrypt23a:icv CRC mismatch: "

    If you made this ("%s:icv ....", __func__, ....

    you wouldn't have to worry about matching the function name to the debug
    text, in case the function later got renamed.

    Cheers,
    Jes

    > "actual: %08x, expected: %08x\n",
    > actual_crc, expected_crc));
    > res = _FAIL;


    \
     
     \ /
      Last update: 2015-03-16 17:41    [W:7.792 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site