lkml.org 
[lkml]   [2015]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] x86/fpu: don't abuse drop_init_fpu() in flush_thread()
    On 03/16, Borislav Petkov wrote:
    >
    > -static inline void drop_init_fpu(struct task_struct *tsk)
    > +/*
    > + * Reset the FPU state in the eager case and drop it in the lazy case (later use
    > + * will reinit it).
    > + */
    > +static inline void fpu_reset_state(struct task_struct *tsk)

    ACK!

    Perhaps you can also find a beter name for __save_init_fpu/etc ;) The
    name clearly suggests that it does "save + init" while in fact it does
    "save and may be destroy FPU state". At least for the callers, the fact
    that "destroy" is actually "init" doesn't really matter.

    But lets not rename it right now. This can conflict with the fixes we
    need to do first.

    Oleg.



    \
     
     \ /
      Last update: 2015-03-16 16:01    [W:2.746 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site