lkml.org 
[lkml]   [2015]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 58/62] HID: fixup the conflicting keyboard mappings quirk
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jiri Kosina <jkosina@suse.cz>

    commit 8e7b341037db1835ee6eea64663013cbfcf33575 upstream.

    The ignore check that got added in 6ce901eb61 ("HID: input: fix confusion
    on conflicting mappings") needs to properly check for VARIABLE reports
    as well (ARRAY reports should be ignored), otherwise legitimate keyboards
    might break.

    Fixes: 6ce901eb61 ("HID: input: fix confusion on conflicting mappings")
    Reported-by: Fredrik Hallenberg <megahallon@gmail.com>
    Reported-by: David Herrmann <dh.herrmann@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hid/hid-input.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/hid/hid-input.c
    +++ b/drivers/hid/hid-input.c
    @@ -1078,6 +1078,7 @@ void hidinput_hid_event(struct hid_devic
    */
    if (!(field->flags & (HID_MAIN_ITEM_RELATIVE |
    HID_MAIN_ITEM_BUFFERED_BYTE)) &&
    + (field->flags & HID_MAIN_ITEM_VARIABLE) &&
    usage->usage_index < field->maxusage &&
    value == field->value[usage->usage_index])
    return;



    \
     
     \ /
      Last update: 2015-03-16 15:41    [W:2.295 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site