Messages in this thread | | | Date | Sun, 15 Mar 2015 11:17:58 +0100 | From | Nicholas Mc Guire <> | Subject | Re: [PATCH 2/2] ath10k: core: harmonize error case handling in ath10k_core_start |
| |
On Sat, 14 Mar 2015, Sergei Shtylyov wrote:
> Hello. > > On 03/14/2015 11:55 AM, Nicholas Mc Guire wrote: > >> All of the bringup/init functions called in ath10k_core_start return 0 on >> success and != 0 on failure - ath10k_wmi_wait_for_service_ready and >> ath10k_wmi_wait_for_unified_ready were adjusted to fit this model and the >> call sites here fixed up accordingly. > > If you've changed the sense of these function's results, you need to > adjust the call sites in the same patch, because otherwise one wouldn't > be able to bisect this... >
yup both patches would mess up if individually applied or reverted. sorry my ignorance - did not think of that problem - will fix it up as a single patch and repost.
thx! hofrat
| |