lkml.org 
[lkml]   [2015]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf hists browser: Fix UI bug after zoom into thread/dso/symbol
    Commit-ID:  a8cd1f4393032cd87e98803346865cdbceb15ad3
    Gitweb: http://git.kernel.org/tip/a8cd1f4393032cd87e98803346865cdbceb15ad3
    Author: He Kuang <hekuang@huawei.com>
    AuthorDate: Wed, 11 Mar 2015 20:36:03 +0800
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Thu, 12 Mar 2015 12:39:59 -0300

    perf hists browser: Fix UI bug after zoom into thread/dso/symbol

    When zoom into thread/dso/symbol, the fold/unfold stat is cleared in
    hists__filter_by_thread/dso/symbol(), but h->nr_rows is not cleared. So
    if we toggle fold stat on the unfold entires, nr_entries got a wrong
    value.

    This bug can be reproduced as follows:

    $ perf record -g -e syscalls:sys_enter_open ls
    $ perf report

    Children Self Command Shared Object Symbol
    ================================================================
    + 50.00% 0.00% ls ld64.so [.] _dl_get_ready_to_run
    - 50.00% 0.00% ls ld64.so [.] _dl_load_shared_library
    _dl_load_shared_library <= [Zoom into thread/dso]
    _dl_get_ready_to_run
    _start
    ...

    In the new thread hists, all entries reset to fold, if we unfold the
    same entry as we previously unfolded, nr_entries got wrong value, and we
    can't move down cursor to bottom row.

    Thread: ls
    Children Self Command Shared Object Symbol
    ================================================================
    + 50.00% 0.00% ls ld64.so [.] _dl_get_ready_to_run
    - 50.00% 0.00% ls ld64.so [.] _dl_load_shared_library
    _dl_load_shared_library
    _dl_get_ready_to_run <= [cursor may stop here, can't move down]
    _start
    ...

    This patch clear h->nr_rows to fix this bug.

    Signed-off-by: He Kuang <hekuang@huawei.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: http://lkml.kernel.org/r/1426077363-855-2-git-send-email-hekuang@huawei.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/hist.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
    index 95f5ab7..d9a6d35 100644
    --- a/tools/perf/util/hist.c
    +++ b/tools/perf/util/hist.c
    @@ -1171,6 +1171,7 @@ static void hists__remove_entry_filter(struct hists *hists, struct hist_entry *h
    /* force fold unfiltered entry for simplicity */
    h->ms.unfolded = false;
    h->row_offset = 0;
    + h->nr_rows = 0;

    hists->stats.nr_non_filtered_samples += h->stat.nr_events;


    \
     
     \ /
      Last update: 2015-03-14 08:21    [W:4.145 / U:1.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site