Messages in this thread | | | Date | Sat, 14 Mar 2015 12:01:32 -0700 | From | Josh Triplett <> | Subject | Re: [PATCH 6/6] clone4: Introduce new CLONE_FD flag to get task exit notification via fd |
| |
On Sat, Mar 14, 2015 at 11:38:29AM -0700, Thiago Macieira wrote: > On Saturday 14 March 2015 15:32:35 Oleg Nesterov wrote: > > It is not clear to me what do_wait() should do with ->autoreap child, even > > ignoring ptrace. > > > > Just suppose that real_parent has a single "autoreap" child. Should > > wait(NULL) hanf then? > > It should ignore the child that is set to autoreap. wait(NULL) should return - > ECHILD, indicating there are no children waiting to be reaped.
Right. And I don't think the current code does this. I think we need to change wait_consider_task to early-return for ->autoreap just as it does for task_state == EXIT_DEAD. I'll do that in v2.
- Josh Triplett
| |