lkml.org 
[lkml]   [2015]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 v2] x86: make 32-bit "emergency stack" better documented
Hi!

> arch/x86/kernel/asm-offsets_32.c | 2 +-
> arch/x86/kernel/cpu/common.c | 3 ++-
> 3 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
> index 48a61c1..9e65cf8 100644
> --- a/arch/x86/include/asm/processor.h
> +++ b/arch/x86/include/asm/processor.h
> @@ -276,9 +276,9 @@ struct tss_struct {
> unsigned long io_bitmap[IO_BITMAP_LONGS + 1];
>
> /*
> - * .. and then another 0x100 bytes for the emergency kernel stack:
> + * and then space for temporary SYSENTER stack:
> */
> - unsigned long stack[64];
> + unsigned long SYSENTER_stack[64];

Would it make sense to make it unsigned char ...stack[256], like the comment said?

Or is it supposed to be different size on 64bit, and comment was wrong?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2015-03-14 17:21    [W:0.525 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site