lkml.org 
[lkml]   [2015]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5 linux-next] udf: remove else after return in __load_block_bitmap()
On Tue 10-03-15 21:44:33, Fabian Frederick wrote:
> else after return is not needed.
Thanks. Applied to my tree.

Honza

>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/udf/balloc.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
> index 30f4641..1cd8916 100644
> --- a/fs/udf/balloc.c
> +++ b/fs/udf/balloc.c
> @@ -63,15 +63,14 @@ static int __load_block_bitmap(struct super_block *sb,
> block_group, nr_groups);
> }
>
> - if (bitmap->s_block_bitmap[block_group]) {
> + if (bitmap->s_block_bitmap[block_group])
> return block_group;
> - } else {
> - retval = read_block_bitmap(sb, bitmap, block_group,
> - block_group);
> - if (retval < 0)
> - return retval;
> - return block_group;
> - }
> +
> + retval = read_block_bitmap(sb, bitmap, block_group, block_group);
> + if (retval < 0)
> + return retval;
> +
> + return block_group;
> }
>
> static inline int load_block_bitmap(struct super_block *sb,
> --
> 1.9.1
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2015-03-14 08:01    [W:0.084 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site