[lkml]   [2015]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes
On (03/13/15 16:39), Minchan Kim wrote:
> AFAIK, kernel rule doesn't prefer multi-line for printk string
> because it makes hard to work with grep. Anyway, it's trivial.
> For example, checkpatch will emit
> WARNING: quoted string split across lines

yes, exactly. that's why I mentioned it in the first place.

well... something like this (a bit ugly, but can do the trick):

pr_warn_once("%d (%s): Attribute %s (and others) will be removed. %s\n"
"See zram documentation.");

will resend the patch later today.

> Anyway, I agree with your way.

thanks for review!


 \ /
  Last update: 2015-03-13 09:21    [W:0.039 / U:7.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site