Messages in this thread | | | Date | Fri, 13 Mar 2015 16:31:55 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH v3 0/2] x86_64: Sigcontext improvements |
| |
On 03/12, Andy Lutomirski wrote: > > Patch 1 is IMO a bug fix.
And personally I agree.
I am still not sure about renames in include/uapi, perhaps someone can ack comment this change...
Perhaps we could could even do
- __u16 __pad0; + // comment to explain that ->ss is used starting from 4.x, + // __pad0 is still here to not break userspace. + union { __u16 __pad0; __u16 ss; }
But this is purely cosmetic, and I simply do not know if we should worry about the potential compilation failure.
I believe both patches are good.
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
| |