[lkml]   [2015]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH RT 29/31] timers: Reduce future __run_timers() latency for newly emptied list
3.10.70-rt75-rc1 stable review patch.
If anyone has any objections, please let me know.


From: "Paul E. McKenney" <>

upstream commit: 16d937f880312e3f47157d4d6d6ebf7e61523378

The __run_timers() function currently steps through the list one jiffy at
a time in order to update the timer wheel. However, if the timer wheel
is empty, no adjustment is needed other than updating ->timer_jiffies.
Therefore, if we just emptied the timer wheel, for example, by deleting
the last timer, we should mark the timer wheel as being up to date.
This marking will reduce (and perhaps eliminate) the jiffy-stepping that
a future __run_timers() call will need to do in response to some future
timer posting or migration. This commit therefore catches ->timer_jiffies
for this case.

Signed-off-by: Paul E. McKenney <>
Reviewed-by: Josh Triplett <>
Acked-by: Peter Zijlstra <>
Reviewed-by: Oleg Nesterov <>
Reviewed-by: Steven Rostedt <>
Tested-by: Mike Galbraith <>
Signed-off-by: Steven Rostedt <>
kernel/timer.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/kernel/timer.c b/kernel/timer.c
index c20bd12a4f06..39f5caef6714 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -691,6 +691,7 @@ detach_expired_timer(struct timer_list *timer, struct tvec_base *base)
if (!tbase_get_deferrable(timer->base))
+ (void)catchup_timer_jiffies(base);

static int detach_if_pending(struct timer_list *timer, struct tvec_base *base,
@@ -706,6 +707,7 @@ static int detach_if_pending(struct timer_list *timer, struct tvec_base *base,
base->next_timer = base->timer_jiffies;
+ (void)catchup_timer_jiffies(base);
return 1;


 \ /
  Last update: 2015-03-13 16:41    [W:0.081 / U:6.172 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site