[lkml]   [2015]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface
On Thu, Mar 12, 2015 at 10:47:54PM +0000, Matt Fleming wrote:
> On Tue, 10 Mar, at 08:51:59AM, Andy Lutomirski wrote:
> >
> > I'm not 100% happy with write(2) (which is all we have in sysfs) for
> > two reasons:
> >
> > 1. If we write a file name, eww. That's more complicated, requires
> > temporary files, has annoying mount namespace issues, etc.
> >
> > 2. If we write the full contents, we need to do it in a single call to
> > write. That means that we can't use cat, which mostly defeats the
> > purpose. In fact, using cat could be actively harmful.
> At this point I'd really like Greg to chime in.
> In principal, I'm not stricly opposed to using a simple char device
> provided that it's not essentially a copy and paste of code from
> drivers/base/firmware_class.c.
> Greg?

Yes, I don't want a character driver here for this if at all possible.
Just stick with the firmware download code, it's there and should work
"as-is" for your stuff.


greg k-h

 \ /
  Last update: 2015-03-13 16:01    [W:0.063 / U:0.376 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site