lkml.org 
[lkml]   [2015]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: sm750fb: braces, indents, spaces fix
On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl script check.

your From: is still having [user] in your email address.
and you are doing too many things in a single patch. one patch should
do only one type of change.

>
>
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
>
this extra blank line is not necessary here.

regards
sudip


\
 
 \ /
  Last update: 2015-03-13 07:21    [W:0.025 / U:0.424 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site