Messages in this thread | | | Date | Fri, 13 Mar 2015 11:00:38 +0100 | From | Michal Marek <> | Subject | Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed |
| |
Dne 13.3.2015 v 05:59 Masahiro Yamada napsal(a): > 2015-03-11 19:01 GMT+09:00 Michal Marek <mmarek@suse.cz>: >> We already have it and it is called "filechk." Valdis, can you check if >> the below patch works equally well for you? > > This looks almost nice, but a few comments below.
Thanks for the review!
>> $(obj)/$(bounds-file): kernel/bounds.s Kbuild > > You are checking the resulting file content, > so the dependency on "Kbuild" is not necessary. > > Instead, you need to add "FORCE" so that this rule is always invoked.
Good point.
>> $(Q)mkdir -p $(dir $@) > > You can drop this line because filechk automatically creates the > output directory.
Likewise.
Michal
| |