Messages in this thread | | | From | Rasmus Villemoes <> | Subject | Re: [PATCH v2 3/4] hwmon: (lm85) replace x_TO_REG() functions with find_closest() | Date | Fri, 13 Mar 2015 09:53:08 +0100 |
| |
On Tue, Mar 10 2015, Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote:
> Replace RANGE_TO_REG() and FREQ_TO_REG() functions with calls > to find_closest(). >
I think the other functions you've replaced only had a single caller, but RANGE_TO_REG is called in two places. It's not a huge function and 2 is not a big number, but maybe it's better to let gcc decide whether to inline the code. So how about leaving the *_TO_REG functions in place and just replace their bodies with the appropriate macro invocation?
Rasmus
| |