lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] mtrr, mm, x86: Enhance MTRR checks for KVA huge page mapping
From
Date
On Thu, 2015-03-12 at 11:03 +0000, Ingo Molnar wrote:
> * Toshi Kani <toshi.kani@hp.com> wrote:
>
> > > Did it perhaps want to be the other way around:
> > >
> > > if (mtrr_state.have_fixed && (start < 0x1000000)) {
> > > ...
> > > } else if (start < 0x100000) {
> > > ...
> > >
> > > or did it simply mess up the condition?
> >
> > I think it was just paranoid to test the same condition twice...
>
> Read the code again, it's _not_ the same condition ...

Oh, I see... It must be a typo. The fixed range is 0x0 to 0xFFFFF, so
it only makes sense to check with (start < 0x100000).

Thanks,
-Toshi



\
 
 \ /
  Last update: 2015-03-12 15:21    [W:0.318 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site