lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 20/30] sparc/PCI: Use pci_scan_host_bridge() for simplicity
>> @@ -667,22 +680,21 @@ struct pci_bus *pci_scan_one_pbm(struct pci_pbm_info *pbm,
>> pbm->busn.end = pbm->pci_last_busno;
>> pbm->busn.flags = IORESOURCE_BUS;
>> pci_add_resource(&resources, &pbm->busn);
>> - bus = pci_create_root_bus(parent,
>> + host = pci_scan_host_bridge(parent,
>> PCI_DOMBUS(pbm->index, pbm->pci_first_busno),
>> - pbm->pci_ops, pbm, &resources);
>> - if (!bus) {
>> - printk(KERN_ERR "Failed to create bus for %s\n",
>> + pbm->pci_ops, pbm, &resources, &phb_ops);
>> + if (!host) {
>> + printk(KERN_ERR "Failed to create host bridge for %s\n",
>> node->full_name);
>> pci_free_resource_list(&resources);
>> return NULL;
>> }
>>
>
> I would keep "bus" and set it here:
>
> bus = host->bus;
>
> That would remove some lines from your patch that really didn't change,
> which makes it easier to see what actually *is* changing, namely, you're
> removing the pci_of_scan_bus() call because it is now done inside
> pci_scan_host_bridge().
>

Yes, keep it will make the code more clean, thanks!

>> - pci_of_scan_bus(pbm, node, bus);
>> - pci_bus_register_of_sysfs(bus);
>> + pci_bus_register_of_sysfs(host->bus);
>>
>> - pci_claim_bus_resources(bus);
>> - pci_bus_add_devices(bus);
>> - return bus;
>> + pci_claim_bus_resources(host->bus);
>> + pci_bus_add_devices(host->bus);
>> + return host->bus;
>> }
>>
>> void pcibios_fixup_bus(struct pci_bus *pbus)
>> --
>> 1.7.1
>>
>
> .
>


--
Thanks!
Yijing



\
 
 \ /
  Last update: 2015-03-12 14:21    [W:0.620 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site