lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 08/30] PCI: Introduce pci_host_assign_domain_nr() to assign domain
>> diff --git a/include/linux/pci.h b/include/linux/pci.h
>> index 8b3d245..2b1b998 100644
>> --- a/include/linux/pci.h
>> +++ b/include/linux/pci.h
>> @@ -1327,11 +1327,15 @@ static inline int pci_domain_nr(struct pci_bus *bus)
>> return bus->domain_nr;
>> }
>> void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent);
>> +void pci_host_assign_domain_nr(struct pci_host_bridge *host);
>
> I do not think this needs to be in include/linux/pci.h. It's called only
> from drivers/pci/host-bridge.c, so at most, it needs to be in
> drivers/pci/pci.h.
>
> Better still would be if the definition could be moved from
> drivers/pci/pci.c to drivers/pci/host-bridge.c so we wouldn't need anything
> in a header file at all.

This is a good idea, thanks.

>
>> #else
>> static inline void pci_bus_assign_domain_nr(struct pci_bus *bus,
>> struct device *parent)
>> {
>> }
>> +static inline void pci_host_assign_domain_nr(struct pci_host_bridge *host)
>> +{
>> +}
>> #endif
>>
>> /* some architectures require additional setup to direct VGA traffic */
>> --
>> 1.7.1
>>
>
> .
>


--
Thanks!
Yijing



\
 
 \ /
  Last update: 2015-03-12 14:01    [W:0.151 / U:2.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site