Messages in this thread | | | Date | Thu, 12 Mar 2015 12:09:51 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: improve algorithm in clflush_cache_range |
| |
* Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> The current algorithm used in clflush_cache_range() can cause the last > cache line of the buffer to be flushed twice. > > Fix that algorithm so that each cache line will only be flushed once, > and remove arithmetic on void pointers. Void pointer arithmetic is > allowed by GCC extensions, but isn't part of the base C standards.
The optimization itself is fine, but that last argument is bogus: the Linux kernel very much relies on 'void *' arithmetics in a gazillion places.
Thanks,
Ingo
| |