Messages in this thread | | | Date | Thu, 12 Mar 2015 11:13:25 +0100 | From | Greg KH <> | Subject | Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro |
| |
On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote: > In sysfs methods struct device is guaranteed to not be NULL thus bd will > not be NULL in any way. Also, checking for bd->magic != DGNC_BOARD_MAGIC > and bd->state != BOARD_READY is redundant because we already don't > initialize broken boards since "dgnc: Don't save boards in memory that > have failed to initialize" and make sysfs files after initializing the > board in dgnc_driver.c or IOW they are already set for successfully > initialized boards before their sysfs files created (412 and 593 lines > in dgnc_driver.c).
As I didn't take your previous patch that this relies on, I can't take this one at this point in time, sorry.
greg k-h
| |