lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86: improve algorithm in clflush_cache_range
From
Date
On Thu, 2015-03-12 at 12:09 +0100, Ingo Molnar wrote:
> * Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
>
> > The current algorithm used in clflush_cache_range() can cause the last
> > cache line of the buffer to be flushed twice.
> >
> > Fix that algorithm so that each cache line will only be flushed once,
> > and remove arithmetic on void pointers. Void pointer arithmetic is
> > allowed by GCC extensions, but isn't part of the base C standards.
>
> The optimization itself is fine, but that last argument is bogus: the
> Linux kernel very much relies on 'void *' arithmetics in a gazillion
> places.

Okay. Are you happy with the patch as is or would you like me to
resubmit with that bit omitted from the change log?

- Ross



\
 
 \ /
  Last update: 2015-03-13 03:41    [W:1.013 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site