lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)
    From
    Date
    On Fri, 2015-03-13 at 00:53 +0100, Mateusz Kulikowski wrote:
    []
    > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
    > index 0e6bdd2..01d2201 100644
    > --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
    > +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
    > @@ -47,8 +47,8 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev,
    > 0x0e, bMask12Bits, 0x021);
    >
    > } else {
    > - RT_TRACE(COMP_ERR, "PHY_SetRF8256Bandwidth(): "
    > - "unknown hardware version\n");
    > + RT_TRACE(COMP_ERR,
    > + "PHY_SetRF8256Bandwidth(): unknown hardware version\n");

    Another thing you might consider is to change these
    embedded function names in another patch to use
    "%s: ", __func__

    RT_TRACE(COMP_ERR,
    "%s: "unknown hardware version\n",
    __func__)

    There's a cocci script for that.
    http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names





    \
     
     \ /
      Last update: 2015-03-13 01:41    [W:2.992 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site