Messages in this thread | | | Date | Wed, 11 Mar 2015 11:45:38 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro |
| |
On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote: > static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr, char *buf) > { > - struct dgnc_board *bd; > - int count = 0; > - int i = 0; > - > - DGNC_VERIFY_BOARD(p, bd); > + int count = 0, i = 0;
Don't redo the patch, but really these should be on separate lines. This is an unwritten rule. :) Also there is no need to set "i".
regards, dan carpenter
| |