lkml.org 
[lkml]   [2015]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro
On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote:
> static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr, char *buf)
> {
> - struct dgnc_board *bd;
> - int count = 0;
> - int i = 0;
> -
> - DGNC_VERIFY_BOARD(p, bd);
> + int count = 0, i = 0;

Don't redo the patch, but really these should be on separate lines.
This is an unwritten rule. :) Also there is no need to set "i".

regards,
dan carpenter


\
 
 \ /
  Last update: 2015-03-11 10:01    [W:0.058 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site